lorawan-stack icon indicating copy to clipboard operation
lorawan-stack copied to clipboard

Support Redis 7

Open johanstokking opened this issue 3 years ago • 0 comments

Summary

Support Redis 7

This issue is not about using Redis 7.0.0 features, but making sure The Things Stack works as intended with Redis 7.0.0.

Why do we need this?

To make sure that users do not need to downgrade Redis to work with The Things Stack.

What is already there? What do you see now?

We currently have support for Redis 6.2.x.

As of now, the only known issue is a failing test:

--- FAIL: TestApplicationUplinkQueue (0.01s)
    --- FAIL: TestApplicationUplinkQueue/Consumers=1 (0.01s)
        --- FAIL: TestApplicationUplinkQueue/Consumers=1/1st_run (0.00s)
            doc.go:66: 
                /home/runner/work/lorawan-stack/lorawan-stack/pkg/networkserver/internal/test/shared/application_uplink_queue.go:140
                Expected: nil
                Actual:   'got 3, wanted 2'
            doc.go:66: 
                /home/runner/work/lorawan-stack/lorawan-stack/pkg/networkserver/internal/test/shared/application_uplink_queue.go:339
                Expected: true
                Actual:   false
        application_uplink_queue_test.go:39: Skipping 2nd run
FAIL
FAIL	go.thethings.network/lorawan-stack/v3/pkg/networkserver/redis	0.083

Which may imply an API change or an API interpretation issue, which may have larger effects that we currently do not test or do not trigger a test failure.

What is missing? What do you want to see?

Make sure The Things Stack works with Redis 7.0.

How do you propose to implement this?

Lots of testing

How do you propose to test this?

CI pass and integration testing

Can you do this yourself and submit a Pull Request?

Can review

johanstokking avatar Apr 29 '22 08:04 johanstokking