GeneralsGamePatch icon indicating copy to clipboard operation
GeneralsGamePatch copied to clipboard

Renaming "Emperor" to "Emperor Overlord" when hovering over it.

Open ghost opened this issue 7 months ago • 4 comments

Just like the training icon. This is a tiny request.

ghost avatar Jul 27 '25 13:07 ghost

Shouldn't it be Emperor Overlord?

OrangeIsALie avatar Aug 11 '25 19:08 OrangeIsALie

Shouldn't it be Emperor Overlord?

You're right, I didn't notice. Nice catch. Fixed it.

ghost avatar Aug 15 '25 12:08 ghost

Fixes #2814

This commit b2d83f5 addresses the localization inconsistencies for the Tank_Overlord unit by making the names consistent with the build UI and correcting some grammatical errors.

The following changes were made:

  • US/DE/ES: Changed "Emperor" to "Emperor Overlord."
  • FR: Changed "Despote" to "Char Despote" for grammatical correctness and clarity.
  • KO: Changed "엠퍼러" to "엠퍼러 오버로드."
  • BP: Changed "Emperor" to "Overlord Emperor."
  • RU: Changed "Император" to "Император-Владыка."
  • UK: Changed "Імператор" to "Імператор-Повелитель."

Please let me know if these changes look good and if I should create a pull request.

Commit Details
OBJECT:Tank_Overlord
- US: "Emperor"
- DE: "Emperor"
- FR: "Despote"
- ES: "Emperor"
+ US: "Emperor Overlord"
+ DE: "Emperor Overlord"
+ FR: "Char Despote"
+ ES: "Emperor Overlord"
IT: "Emperor"
- KO: "엠퍼러"
+ KO: "엠퍼러 오버로드"
ZH: "帝王坦克"
- BP: "Emperor"
+ BP: "Overlord Emperor"
PL: "Cesarz"
- RU: "Император"
+ RU: "Император-Владыка"
AR: "ﺔﻳرﻮﻃاﺮﺒﻣﻹا ﺔﺑﺎﺑﺪﻟا"
- UK: "Імператор"
+ UK: "Імператор-Повелитель"
END

Polypheides avatar Aug 24 '25 21:08 Polypheides

You can leave RU and UK variants as they are. I already consulted with Windstalker and xezon about this case, and It's alright to leave them as they are in these localizations. I have no opinion on other localizations, so more input would be required for this change to pass.

dmgreeny avatar Aug 25 '25 18:08 dmgreeny