TheSuperHackers
Fix Adding missing Arabic and Ukrainian in various JSON
Here is the requested Ukrainian addition together with a Missing? Arabic entry in Patch104pZH/ModBundleOptionalLanguageItems.json
Ukrainian will not build yet unless added to the gametextcompiler this will be fixed later
My changes for gametextcompiler ~~gametextcompiler code Ukrainian UA~~ ~~gametextcompiler code Ukrainian UK~~ ~~gametextcompiler code Swedish SV and Ukrainian UK~~ ~~gametextcompiler code Swedish SV, Ukrainian UK, Azerbaijani AZ Turkish TR~~ gametextcompiler code Now adds almost all the languages in the world
~~I have also added _comments for each community-made language~~
Reason for the Swedish entries seen in the files changed is because Ukrainian entries comes after Swedish alphabetically in the JSON and that the Swedish PR #2715 is not merged yet.
- Closes: https://github.com/TheSuperHackers/GeneralsGamePatch/issues/2668
is this ready to review?
All my pull request are always ready for scrutiny. So yes you may review it but we still miss critical fixes for the changes to work 'gametextcompiler'.
and #2715 comes first in the commit chain that needs reviewing and approval adding Swedish.
my latest iteration of gametextcompiler works with both SV and UK https://github.com/Polypheides/Thyme/commit/95138dc9717b411b90dca9cb0b378bcbf3aa731c but contains comments in code that we might not want in the 'gametextcompiler' main branch.
"I have a commit for this pull request waiting to be pushed, removing _comment. xezon argued against adding comments to these files (#2715). We'll see what he decides."
I think this comment is not necessary here. There already is a wiki page somewhere which could list the original game languages, which then implies which ones are community made.
Here is the wiki page https://github.com/TheSuperHackers/GeneralsGamePatch/wiki/localization_contribution