GeneralsGamePatch icon indicating copy to clipboard operation
GeneralsGamePatch copied to clipboard

Fix yaml XP rewards for China Hacker

Open DevGeniusCode opened this issue 11 months ago • 7 comments

DevGeniusCode avatar Mar 19 '25 00:03 DevGeniusCode

Nice. Can you bundle more doc/script fixes into your change? I want to avoid many small changes doing small fixups for the similar kinds of things.

  • #2688
  • #2646 See notes:
  • #2596

xezon avatar Mar 19 '25 07:03 xezon

Nice. Can you bundle more doc/script fixes into your change? I want to avoid many small changes doing small fixups for the similar kinds of things.

I have added updates in the links above.

I think it's now possible to create two merges, one commit for mod Builder, and a second commit for yaml file fixes

DevGeniusCode avatar Mar 22 '25 14:03 DevGeniusCode

What do you mean with "commit for Mod Builder" ? I think all the changes linked here can be merged into one change for fixing Documentation.

xezon avatar Mar 25 '25 10:03 xezon

What do you mean with "commit for Mod Builder" ? I think all the changes linked here can be merged into one change for fixing Documentation.

I mean this 3 PRs from @Polypheides , I think they are not related to yaml files #2717, #2715, #2688

image

DevGeniusCode avatar Mar 25 '25 12:03 DevGeniusCode

Ok. But #2646 is.

I would like to see #2688 cramped into another change. We should not make many one liner commits, because it will pollute the commit history.

xezon avatar Mar 25 '25 13:03 xezon

Maybe make this pull request a general "Fix for various Documents" bundle.

Polypheides avatar Mar 25 '25 13:03 Polypheides

Can close the current PR, the commit for the current PR has been moved to #2646

DevGeniusCode avatar Mar 25 '25 20:03 DevGeniusCode