TheSuperHackers
Improve the particle effect for destroyed GLA Demo units
This change improves the particle effect for destroyed GLA Demo units. It now looks more similar to the regular Demo Suicide explosion, but with slightly smaller effects and without the explosion pillars.
I want to try this first. The difference should be very noticable, since it does vastly different amounts of damage. 1.04 already is not very clear about this.
Yea, glow helps. Right one looks kind of big though. It does pathetic damage, so it really should just be a puff. The donut adds to the size and probably too much.
It does not deal much damage, but it has huge damage radius. Bigger than suicide radius. Also keep in mind it needs to fit on vehicles. If it is too small, it will look unfitting.
I made a bit smaller now. Check.
commy2
Re visuals: I think the donut could be smaller. I mean, same radius obv, but smaller wall thickness. Or maybe the radius could be decreased if it is also decided that the secondary damage radius should be 50 instead of 70.
xezon
We can reduce the radius to match or undercut suicide radius yes. Does not make sense that it is larger than suicide.
Edit:
- Done with #2420
I've noticed that there's a continuous effects performance degradation the longer the game goes vs demo. Some visual & transition effects stop displaying the more demo units you kill & the more explosion they produce. I've tried playing with ParticleSystems Priority - changing from CRITICAL & WEAPON_EXPLOSION to DEATH_EXPLOSION but that didn't solve the issue.
Seems like effects are accumulating and prevent other effects from displaying fully. Similar to when you have too many firestorms simultaneously.
Can you try to figure out which particle system is causing it? It needs its own bug report. Likewise we know that DisabledEffectBinaryShower0 is causing problems (#1739).
Can you try to figure out which particle system is causing it? It needs its own bug report. Likewise we know that
DisabledEffectBinaryShower0is causing problems (#1739).
I've tried switching back to WeaponFX_DemoSuicideDynamitePackDetonationPlusFire but the result is the same.
Commented out ExplosionSmall and DemoExplosionSmokeLite -- a bit better but still accumulates.
Set SystemLifetime for these new small ParticleSystems similar to WeaponFX_DemoSuicideDynamitePackDetonationPlusFire but no difference.
I'm sorry, I don't have much experience dealing with ParticleSystem items... You could try his on your side, just killing Demo AI units at his base (after demo upgrade) and observe how effects seem to stuck more and more...
BTW, in https://github.com/TheSuperHackers/GeneralsGamePatch/issues/1519 you've turned questionable ParticleSystem into green for debugging -- can you please share how that could be done? I want to debug this as well and check out couple more effects I have my doubts about.
Is this performance bug Patch specific or in Original game?
Seems to be Patch, original plays all animations no matter how many units/buildings you kill in at demo base...