RandomPatches icon indicating copy to clipboard operation
RandomPatches copied to clipboard

Conflict with Mouse Wheelie: Breaks Toggle Sneak/Sprint

Open Fourmisain opened this issue 4 years ago • 1 comments

Refering to https://github.com/Siphalor/mouse-wheelie/issues/111, specifically https://github.com/Siphalor/mouse-wheelie/issues/111#issuecomment-793531338

Having both Mouse Wheelie and RamdomPatches installed breaks Toggle Sneak and Toggle Sprint completely, meaning you cannot switch the states - as if the key presses are not registering or are blocked somehow.

On this end, I brought it down to this piece of code: https://github.com/TheRandomLabs/RandomPatches/blob/291a49bf05ec37312680287202e5d6b65eeb1d73/src/main/java/com/therandomlabs/randompatches/mixin/client/keybindings/KeyBindingMixin.java#L108-L114

Removing it, "fixes" the issue/conflict.

Setting mixin_blacklist = ["KeyBinding"] inside randompatches.toml is a practical workaround (for default settings) for now.

On Mouse Wheelie's end, I'm not quite sure what's causing the issue, it may have something to do with SortKeyBinding since that uses both shift and control as possible modifiers and it is a PriorityKeyBinding, which given the name suggests it could block other keybindings?

I could be completely mistaken about this, maybe you can shed some light on this?

Fourmisain avatar Mar 09 '21 08:03 Fourmisain

Update: It's not about Mouse Wheelie directly but about amecs. Probably related to https://github.com/Siphalor/amecs/issues/31.

Fourmisain avatar Mar 09 '21 09:03 Fourmisain