css-exercises icon indicating copy to clipboard operation
css-exercises copied to clipboard

Bug - :

Open tushar-raven opened this issue 2 years ago • 5 comments

Complete the following REQUIRED checkboxes:

  • [x] I have thoroughly read and understand The Odin Project Contributing Guide
  • [x] The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - Grid exercises: CSS not properly linked to HTML files

The following checkbox is OPTIONAL:

  • [x] I would like to be assigned this issue to work on it

1. Description of the Bug:

There is an extra line of code in the solution of the "pop-up" exercise under the animation section. Screenshot 2023-08-18 at 8 10 52 PM

2. How To Reproduce:

Visit css-exercises/animation/pop-up/solution/solution.js

3. Expected Behavior:

The code doesn't do anything.

4. Desktop/Device:

  • Device:
  • OS:
  • Browser:
  • Version:

OS

5. Additional Information:

tushar-raven avatar Aug 18 '23 14:08 tushar-raven

Seems like it's not needed to me as well, thanks for reporting, assigned!

wise-king-sullyman avatar Aug 22 '23 02:08 wise-king-sullyman

I think the guy was trying to set "closing by clicking on the backdrop" but it didn't work.

tushar-raven avatar Aug 26 '23 13:08 tushar-raven

@tushar-raven you have been assigned this issue a few weeks back. Are you still willing to work on this?

ManonLef avatar Oct 02 '23 09:10 ManonLef

I am sorry, I didn't know it was assigned to me. I will work on it.

Thanks!

tushar-raven avatar Oct 02 '23 09:10 tushar-raven

No problem, I thought as much and hence the reminder! Thank you for doing this

ManonLef avatar Oct 02 '23 09:10 ManonLef

I will take this.

UniquePixels avatar Apr 21 '24 15:04 UniquePixels

Well that was freaky timing just as I look at this issue :fearful:

Assigned you, @fabulousgk

mao-sz avatar Apr 21 '24 15:04 mao-sz

Haha, I came here to open an issue, and saw this one just hanging around.

UniquePixels avatar Apr 21 '24 15:04 UniquePixels