TheInvincible comments

Results 30 comments of


                                            TheInvincible

used false as default for useMilitaryTime

Hi, @hmhealey. I have made another pull request for the preference test at https://github.com/mattermost/mattermost/pull/28128/commits/1f85178d27cfc18ef368f2a1a531a6d8eb4dd066

Fix errcheck issue in oauth.go

> @TheInvincibleRalph Thanks for the contribution. Looks like there are some more unchecked errors: > > ``` > Error: channels/web/oauth.go:207:13: Error return value of `r.ParseForm` is not checked (errcheck) r.ParseForm()...

Fix errcheck issue in oauth.go

/update-branch

Fix errcheck issue in oauth.go

/update-branch

Fix errcheck issue in oauth.go

> LGTM, just need to fix the conflicts. Thanks 🚀 Done

Fix errcheck issue in oauth.go

@hanzei, this hasn't been merged.

Fix errcheck issue in oauth.go

/update-branch

Save server CLI commands to file

Hi, @Aptimex, I need more context to this issue. Where is the `wiretap_server.conf` file located in the project directory?

Failed test at Mocking tutorial

The function was refactored in the main file you sent: ``` func Countdown(out io.Writer, sleeper Sleeper) { for i := countdownStart; i > 0; i-- { fmt.Fprintln(out, i) sleeper.Sleep() }...

Show last job status in UI in jobs list

Hi, @philrenaud. I am interested in taking this but could you give more context as to what to do?