Walnut icon indicating copy to clipboard operation
Walnut copied to clipboard

Random float problem in some compiler or platform

Open WeebOwO opened this issue 3 years ago • 0 comments

1. Describe the bug

In some compiler or platform, std::mt19937::result_type will not be unsigned int, this will cause Float() not in 0~1 range. https://github.com/TheCherno/Walnut/blob/3b8e414fdecfc6c8b58816106fe8d912bd172e31/Walnut/src/Walnut/Random.h#L48

图片

图片

2. Desktop

  • Os: Ubuntu 22.04
  • Compiler: Gcc 11.3
  • Cpu: Ryzen™ 5 4600G

3. My fix solution

explicit declare type like below

 static std::uniform_int_distribution<uint32_t> s_Distribution; 

WeebOwO avatar Jan 31 '23 01:01 WeebOwO