Python icon indicating copy to clipboard operation
Python copied to clipboard

pre-commit: Update to mypy v1.0

Open cclauss opened this issue 2 years ago • 2 comments

Describe your change:

Mypy has finally reached v1.0.

  • https://mypy.readthedocs.io/en/stable/

  • [ ] Add an algorithm?

  • [ ] Fix a bug or typo in an existing algorithm?

  • [ ] Documentation change?

  • [x] Change to testing infrastructure

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ ] All new Python files are placed inside an existing directory.
  • [ ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ ] All functions and variable names follow Python naming conventions.
  • [ ] All function parameters and return values are annotated with Python type hints.
  • [ ] All functions have doctests that pass the automated testing.
  • [ ] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss avatar Feb 07 '23 18:02 cclauss

I think pre-commit automatically updates the versions periodically, right? Why are we doing this manually then?

dhruvmanila avatar Feb 08 '23 02:02 dhruvmanila

Because this is an upgrade to v1.0 and I wanted to understand if there were breaking changes before I applied this upgrade to other repos that I work on.

cclauss avatar Feb 08 '23 06:02 cclauss

Fixed in #8141

cclauss avatar Feb 13 '23 21:02 cclauss