Python icon indicating copy to clipboard operation
Python copied to clipboard

Reduce the complexity of other/scoring_algorithm.py

Open MaximSmolskiy opened this issue 3 years ago • 2 comments

Describe your change:

Reduce the complexity of other/scoring_algorithm.py from 16 to 10

  • [ ] Add an algorithm?
  • [x] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

MaximSmolskiy avatar Dec 24 '22 15:12 MaximSmolskiy

Maybe I am misunderstanding something, but why is the max complexity being increased?

It was decreased in #7954, but now there are algorithms with greater complexity.

MaximSmolskiy avatar Dec 24 '22 18:12 MaximSmolskiy

@cclauss please review

MaximSmolskiy avatar Feb 24 '23 17:02 MaximSmolskiy