Python icon indicating copy to clipboard operation
Python copied to clipboard

Add Big O Notation

Open mttgermano opened this issue 3 years ago • 4 comments

Describe your change:

Added Big O Notation for the 'find_min' algorithm

  • [ ] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [X] Documentation change?

Checklist:

  • [X] I have read CONTRIBUTING.md.
  • [X] This pull request is all my own work -- I have not plagiarized.
  • [X] I know that pull requests will not be merged if they fail the automated tests.
  • [X] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [X] All new Python files are placed inside an existing directory.
  • [X] All filenames are in all lowercase characters with no spaces or dashes.
  • [X] All functions and variable names follow Python naming conventions.
  • [X] All function parameters and return values are annotated with Python type hints.
  • [X] All functions have doctests that pass the automated testing.
  • [X] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

mttgermano avatar Oct 11 '22 00:10 mttgermano

Can you mention about the space complexity?

sure!

mttgermano avatar Oct 14 '22 12:10 mttgermano

Hey @mttgermano, you have two other PRs #6963 and #6962 open with the same name. Keeping your most recent PR, close the rest of them to avoid duplication.

ZeroDayOwl avatar Oct 16 '22 04:10 ZeroDayOwl

Hey @mttgermano, you have two other PRs #6963 and #6962 open with the same name. Keeping your most recent PR, close the rest of them to avoid duplication.

Although the PRs have the same name, they change different files. Is it better to just put them all in a single PR?

mttgermano avatar Oct 16 '22 04:10 mttgermano

Hey @mttgermano, you have two other PRs #6963 and #6962 open with the same name. Keeping your most recent PR, close the rest of them to avoid duplication.

Although the PRs have the same name, they change different files. Is it better to just put them all in a single PR?

Sure, just put all of them in a single PR stating what you changed in which file.

ZeroDayOwl avatar Oct 16 '22 12:10 ZeroDayOwl