Python icon indicating copy to clipboard operation
Python copied to clipboard

adding the remove digit algorithm

Open meg-1 opened this issue 3 years ago • 2 comments

Describe your change:

this algorithm returns the biggest possible result that can be achieved by removing one digit from the given number.

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

meg-1 avatar Oct 05 '22 14:10 meg-1

@CaedenPH @cclauss , just fixed the errors in this algorithm! it's ready for a merge :)

meg-1 avatar Nov 16 '22 15:11 meg-1

credits to @CaedenPH and @alexpantyukhin for the feedback from #7995 ! just implemented it :)

meg-1 avatar Nov 23 '22 15:11 meg-1