Python icon indicating copy to clipboard operation
Python copied to clipboard

create quantum_fourier_transform

Open KevinJoven11 opened this issue 3 years ago • 3 comments

This is part of the #Hacktoberfest. I build the quantum fourier transform for N qubits. (n = 3 in the example) Best, Kevin

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

KevinJoven11 avatar Oct 05 '22 04:10 KevinJoven11

@cclauss Hi! Sorry for ping you. I just wanna know if this repo (Algorithms/Python) is not more part of the #Hacktoberfest or is there another reason for that. I just wanna have my second contribution to the hackfest to have the t-shirt. Best,

KevinJoven11 avatar Oct 15 '22 00:10 KevinJoven11

We had a handful of pull requests when October started and we have almost 200 now so I view Hacktoberfest to be a bit of a denial of service attack on my productivity but we do give out the labels (added here) for pull requests that meet out CONTRIBUTING.md requirements.

A function name like qft() is not self-documenting. Also we require doctests.

cclauss avatar Oct 15 '22 05:10 cclauss

Extra credit: In a separate pull request, fix the PendingDeprecationWarning that pytest is raising in our automated testing… https://github.com/TheAlgorithms/Python/actions/runs/3254565205/jobs/5342967879#step:6:644

cclauss avatar Oct 15 '22 06:10 cclauss