Python
Python copied to clipboard
Bytes to Int
Describe your change:
- [x] Add an algorithm?
- [ ] Fix a bug or typo in an existing algorithm?
- [ ] Documentation change?
Checklist:
- [x] I have read CONTRIBUTING.md.
- [x] This pull request is all my own work -- I have not plagiarized.
- [x] I know that pull requests will not be merged if they fail the automated tests.
- [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
- [x] All new Python files are placed inside an existing directory.
- [x] All filenames are in all lowercase characters with no spaces or dashes.
- [x] All functions and variable names follow Python naming conventions.
- [x] All function parameters and return values are annotated with Python type hints.
- [x] All functions have doctests that pass the automated testing.
- [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
- [x] If this pull request resolves one or more open issues then the commit message contains
Fixes: #{$ISSUE_NO}.
Hi, I committed the change, can you please add a hacktoberfest label to the commit?
On Mon, Oct 3, 2022 at 3:24 PM Christian Clauss @.***> wrote:
@.**** commented on this pull request.
In conversions/bytes_to_int.py https://github.com/TheAlgorithms/Python/pull/6590#discussion_r985594806:
if flag is True:
temp = str(temp) + "1"else:temp = str(temp) + "0"⬇️ Suggested change
if flag is True:temp = str(temp) + "1"else:temp = str(temp) + "0"
temp += str(int(flag))— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/Python/pull/6590#pullrequestreview-1128102529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZAMR4GBU7OL6FGPRPTMQY3WBKUM7ANCNFSM6AAAAAAQ3JTJWQ . You are receiving this because you modified the open/close state.Message ID: @.***>