Python icon indicating copy to clipboard operation
Python copied to clipboard

Added implementation for valid parentheses in string

Open ajinkyac03 opened this issue 3 years ago • 4 comments

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Fixes https://github.com/TheAlgorithms/Python/issues/6354

ajinkyac03 avatar Sep 08 '22 10:09 ajinkyac03

@cclauss please have a look.

ajinkyac03 avatar Sep 13 '22 10:09 ajinkyac03

Duplicate of https://github.com/TheAlgorithms/Python/blob/master/data_structures/stacks/balanced_parentheses.py ?

cclauss avatar Sep 13 '22 11:09 cclauss

How is this algorithm better than our existing balanced_parentheses.py?

cclauss avatar Sep 19 '22 15:09 cclauss

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 02 '22 06:11 stale[bot]

@cclauss Close this PR? It's stale, and it's a duplicate implementation like you said

tianyizheng02 avatar Jun 08 '23 02:06 tianyizheng02