Python icon indicating copy to clipboard operation
Python copied to clipboard

Improve Project Euler problem 203 solution 1

Open MaximSmolskiy opened this issue 3 years ago • 0 comments

Describe your change:

Improve Project Euler problem 203 solution 1 - the top 9 slowest solution on GitHub Actions logs (under slowest 10 durations: 3.46s call scripts/validate_solutions.py::test_project_euler[problem_203/sol1.py]):

  • Improve solution (locally 1500+ times - from 3+ seconds to ~2 milliseconds)

  • [ ] Add an algorithm?

  • [x] Fix a bug or typo in an existing algorithm?

  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

MaximSmolskiy avatar Jul 28 '22 20:07 MaximSmolskiy