Python icon indicating copy to clipboard operation
Python copied to clipboard

fix bucket_sort.py

Open Whisht opened this issue 3 years ago • 2 comments

Describe your change:

  • [ ] Add an algorithm?
  • [x] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}. Original bucket_sort didn't do exact bucket sort, it just put all values to the first bucket and do sorted.

Whisht avatar Mar 21 '22 13:03 Whisht

Original bucket sort implement simply divide bucket with size=1,so all the elements are put into the first bucket. It is no difference between sorted function. I added a variable bucket_size that one can divide an array to (max_val - min_val)//bucket_size + 1 buckets and apply bucket_sort.

Whisht avatar Mar 21 '22 13:03 Whisht

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 14:07 stale[bot]

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that have failing tests.

cclauss avatar Oct 01 '22 10:10 cclauss