Python Kinematics
Describe your change:
- [x] Add an algorithm?
- [ ] Fix a bug or typo in an existing algorithm?
- [ ] Documentation change?
Checklist:
- [x] I have read CONTRIBUTING.md.
- [x] This pull request is all my own work -- I have not plagiarized.
- [x] I know that pull requests will not be merged if they fail the automated tests.
- [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
- [ ] All new Python files are placed inside an existing directory.
- [x] All filenames are in all lowercase characters with no spaces or dashes.
- [x] All functions and variable names follow Python naming conventions.
- [x] All function parameters and return values are annotated with Python type hints.
- [x] All functions have doctests that pass the automated testing.
- [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
- [ ] If this pull request resolves one or more open issues then the commit message contains
Fixes: #{$ISSUE_NO}.
For simplicity and conciseness, I named my variables the same as the variables used to represent certain values in kinematic equations. Examples: https://www.physicsclassroom.com/class/1dkin/Lesson-6/Kinematic-Equations ("d" or "distance" is represented by "x-x0" or "final position minus initial position")
Don't do that. Why are you forcing your reader to guess if d is distance, or dimension or delta? We are not trying to be simple or concise. We are trying to teach. Guessing is not helpful to understanding.
Don't do that. Why are you forcing your reader to guess if
disdistance, ordimensionordelta? We are not trying to be simple or concise. We are trying to teach. Guessing is not helpful to understanding.
Fair point, I will add changes accordingly. And I also noticed that type hints failed as well and I assume I'm supposed to use the "typing_extensions" module rather than the "typing" module.
typing_extensions is not used by programmers. It is used by mypy so it can be ignored.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that do not have passing tests.