Python icon indicating copy to clipboard operation
Python copied to clipboard

add algorithm to check if given string is valid number or not

Open reniz-shah opened this issue 1 year ago • 2 comments

Add a new file string_is_valid_number.py in string directory

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [x] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

reniz-shah avatar Jul 08 '24 10:07 reniz-shah

Need to migrate to NumPy 2.0 as ruff tests are failing or need to change test configurations

Below is the error raised by ruff check graphs/multi_heuristic_astar.py:82:12: NPY201 np.chararray will be removed in NumPy 2.0. Use numpy.char.chararray instead.

reniz-shah avatar Jul 08 '24 11:07 reniz-shah

Please rebase this pull request on the current master branch.

cclauss avatar Aug 07 '24 16:08 cclauss