Python icon indicating copy to clipboard operation
Python copied to clipboard

The sum of outcomes for rolling an N-sided dice K times.

Open dipuk0506 opened this issue 1 year ago • 6 comments

Describe your change:

  • [x] Add an algorithm?

    The sum of outcomes for rolling an N-sided dice K times.

    This function returns a list. The last two elements are the range of probability distribution. The range is: 'k_time' to 'k_time*n_side'

    Other elements contain probabilities for getting a summation from 'k_time' to 'k_time*n_side'.

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [x] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

dipuk0506 avatar Jun 15 '24 02:06 dipuk0506

Hi, If you have any confusion about the algorithm, you can email me at [email protected] and arrange a meeting.

dipuk0506 avatar Jun 16 '24 09:06 dipuk0506

Please email me, if you are confused.

dipuk0506 avatar Jun 19 '24 02:06 dipuk0506

There are two typos in comments. Everything else seems correct.

Lines 40 and 41 will be as follows:

The probability of getting 2 is 1/36. The probability of getting 3 is 2/36.

dipuk0506 avatar Jun 19 '24 05:06 dipuk0506

Please approve

dipuk0506 avatar Jun 20 '24 03:06 dipuk0506

For theory visit the wiki page: https://en.wikipedia.org/wiki/Convolution_of_probability_distributions

For more explanation of the theory please visit my GitHub repository: https://github.com/dipuk0506/dice

Please correct 2 typos and merge.

dipuk0506 avatar Jun 25 '24 00:06 dipuk0506

Please Merge the request.

dipuk0506 avatar Jul 05 '24 00:07 dipuk0506