Python icon indicating copy to clipboard operation
Python copied to clipboard

Triangle Centers

Open alex-buchanan opened this issue 2 years ago • 2 comments

Describe your change:

Provide a Way of Calculating Different Triangle Centers

  • [X] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • [ ] Documentation change?

Checklist:

  • [ X ] I have read CONTRIBUTING.md.
  • [ X ] This pull request is all my own work -- I have not plagiarized.
  • [ X ] I know that pull requests will not be merged if they fail the automated tests.
  • [ X ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ X ] All new Python files are placed inside an existing directory.
  • [ X ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ X ] All functions and variable names follow Python naming conventions.
  • [ X ] All function parameters and return values are annotated with Python type hints.
  • [ X ] All functions have doctests that pass the automated testing.
  • [ X ] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

alex-buchanan avatar Dec 06 '23 02:12 alex-buchanan

I'm not sure why pytest fails in the automated check, if the reviewer has any suggestions or requests on how to clear this test it would be much appreciated.

alex-buchanan avatar Dec 06 '23 03:12 alex-buchanan

Reviewers: Is anything still missing here? The automated tests are all passing, just waiting on a reviewer to check it off / out. Anything I can do to help?

alex-buchanan avatar Dec 13 '23 15:12 alex-buchanan