Python icon indicating copy to clipboard operation
Python copied to clipboard
Published 1 month ago • verified publisher icon TheAlgorithms

Fix Bug: Missing Edge Case for odd_even_transposition_parallel.py

Open gyan313 opened this issue 2 years ago • 3 comments

Describe your change:

This enhanced code includes fixed bugs pointed out by @RaymondDashWu. The problem with the Algorithm was that it assumed the length of the array to be sorted equal to 10 (check the 1st for loop inside the function oe_process), which is why when @RaymondDashWu tried sorting an array with length 11, the returned sorted array is not as expected. So, I just passed an argument named arr_len which contains the array's length value. In addition to fixing this bug, this code includes exception handling for user input, and more detailed docstrings. It's now more robust and readable.

  • [ ] Add an algorithm?
  • [x] Fix a bug or typo in an existing algorithm?
  • [ ] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Python files are placed inside an existing directory.
  • [x] All filenames are in all lowercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Python naming conventions.
  • [x] All function parameters and return values are annotated with Python type hints.
  • [x] All functions have doctests that pass the automated testing.
  • [x] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [x] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

gyan313 avatar Oct 26 '23 02:10 gyan313

Hi, can any of the admins merge this pr, if possible✌️

gyan313 avatar Oct 26 '23 13:10 gyan313

Hi, can any of the admins merge this pr, if possible✌️

Hey @tianyizheng02 can you please review this pr.❤️ THANKS

gyan313 avatar Oct 26 '23 18:10 gyan313

This branch has conflicts that must be resolved

sorts/odd_even_transposition_parallel.py

cclauss avatar Oct 27 '23 21:10 cclauss