JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Fix friendly numbers

Open W0uldYouKindly opened this issue 2 months ago • 2 comments

Open in Gitpod know more

Describe your change:

  • [ ] Add an algorithm?
  • [☑] Fix a bug or typo in an existing algorithm? (Commit message contains description of changes)
  • [ ] Documentation change?

Checklist:

  • [ ☑] I have read CONTRIBUTING.md.
  • [ ☑] This pull request is all my own work -- I have not plagiarized.
  • [ ☑] I know that pull requests will not be merged if they fail the automated tests.
  • [☑ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ ☑] All new JavaScript files are placed inside an existing directory.
  • [☑ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ ☑] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ☑] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

W0uldYouKindly avatar Nov 11 '25 15:11 W0uldYouKindly

Codecov Report

:x: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 85.91%. Comparing base (08d8c6b) to head (66f25c8).

Files with missing lines Patch % Lines
Maths/FriendlyNumbers.js 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1856   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         379      379           
  Lines       19778    19778           
  Branches     3015     3015           
=======================================
  Hits        16993    16993           
  Misses       2785     2785           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Nov 11 '25 15:11 codecov-commenter

any updates?

W0uldYouKindly avatar Nov 19 '25 13:11 W0uldYouKindly