JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Changed implementation of slope calculation

Open Haarush2006 opened this issue 2 months ago • 2 comments

Fix/

Changed implementation of slope calculation Added cross product logic instead of math slope formula

fixes #1815

  • [x] Fix a bug or typo in an existing algorithm?

Checklist:

  • [X] I have read CONTRIBUTING.md.
  • [X] This pull request is all my own work -- I have not plagiarized.
  • [X] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [X] All new JavaScript files are placed inside an existing directory.
  • [X] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [X] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [X] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Haarush2006 avatar Oct 23 '25 14:10 Haarush2006

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 85.91%. Comparing base (08d8c6b) to head (914e525).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1847      +/-   ##
==========================================
- Coverage   85.91%   85.91%   -0.01%     
==========================================
  Files         379      379              
  Lines       19778    19772       -6     
  Branches     3015     3014       -1     
==========================================
- Hits        16993    16987       -6     
  Misses       2785     2785              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Oct 23 '25 14:10 codecov-commenter

@appgurueu @raklaptudirm pls review my pr

Haarush2006 avatar Oct 24 '25 17:10 Haarush2006