JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Added Miller Rabin Primality test

Open Amal-Verma opened this issue 1 year ago • 2 comments

Open in Gitpod know more

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Amal-Verma avatar Oct 23 '24 04:10 Amal-Verma

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 84.46%. Comparing base (55ff0ad) to head (dcb2a73).

Files with missing lines Patch % Lines
Maths/MillerRabin.js 0.00% 70 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
- Coverage   84.76%   84.46%   -0.30%     
==========================================
  Files         378      379       +1     
  Lines       19738    19808      +70     
  Branches     2957     2958       +1     
==========================================
  Hits        16731    16731              
- Misses       3007     3077      +70     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 23 '24 04:10 codecov-commenter

@raklaptudirm @appgurueu Please review this PR

Amal-Verma avatar Oct 25 '24 05:10 Amal-Verma