JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Feature/problem 26

Open abda-gaye opened this issue 1 year ago • 3 comments

Describe your change:

  • [x] Add an algorithm?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames use the UpperCamelCase (PascalCase) style.
    • Example: Problem026.js and Problem026.test.js are allowed.
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ] If this pull request resolves one or more open issues, then the commit message contains Fixes: #{$ISSUE_NO}

Algorithm Description

I have implemented a new algorithm in the Problem026.js file, along with a corresponding test file Problem026.test.js to ensure its functionality. This algorithm addresses the problem described in the following link: Project Euler Problem 26.

abda-gaye avatar Oct 20 '24 19:10 abda-gaye

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.85%. Comparing base (ff314a2) to head (c6192d7). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1740      +/-   ##
==========================================
+ Coverage   84.76%   84.85%   +0.08%     
==========================================
  Files         378      380       +2     
  Lines       19742    19855     +113     
  Branches     2955     2978      +23     
==========================================
+ Hits        16735    16848     +113     
  Misses       3007     3007              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 20 '24 19:10 codecov-commenter

I think that it's good

Le dim. 20 oct. 2024 à 19:50, Codecov Comments Bot @.***> a écrit :

Codecov https://app.codecov.io/gh/TheAlgorithms/JavaScript/pull/1740?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (ff314a2) https://app.codecov.io/gh/TheAlgorithms/JavaScript/commit/ff314a2bed38525af0445fde53e37338b4db3406?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms to head (c6192d7) https://app.codecov.io/gh/TheAlgorithms/JavaScript/commit/c6192d760d9d097352d49ccb49a76dd189309927?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms . Report is 1 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #1740 +/- ## ==========================================+ Coverage 84.76% 84.85% +0.08%

Files 378 380 +2 Lines 19742 19855 +113 Branches 2955 2978 +23 ==========================================+ Hits 16735 16848 +113 Misses 3007 3007

☔ View full report in Codecov by Sentry https://app.codecov.io/gh/TheAlgorithms/JavaScript/pull/1740?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms . 📢 Have feedback on the report? Share it here https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms .

— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/JavaScript/pull/1740#issuecomment-2425193660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZGAU5ISXSHU72IAL4GUXUDZ4QCQFAVCNFSM6AAAAABQIZ2ANWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRVGE4TGNRWGA . You are receiving this because you authored the thread.Message ID: @.***>

abda-gaye avatar Oct 20 '24 20:10 abda-gaye

When are you going to look at my contribution?

abda-gaye avatar Oct 30 '24 16:10 abda-gaye