JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

feat: add find line segment Intersection algorithm

Open saahil-mahato opened this issue 1 year ago • 2 comments

Open in Gitpod know more

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

saahil-mahato avatar Oct 02 '24 04:10 saahil-mahato

Codecov Report

Attention: Patch coverage is 87.93970% with 24 lines in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (9010481) to head (49de7a5). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
Geometry/FindIntersections.js 87.93% 24 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
+ Coverage   84.65%   84.69%   +0.03%     
==========================================
  Files         378      379       +1     
  Lines       19744    19943     +199     
  Branches     2951     2981      +30     
==========================================
+ Hits        16715    16890     +175     
- Misses       3029     3053      +24     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 02 '24 05:10 codecov-commenter

I have made changes. Please review and let me know if anything is missing. Thanks.

saahil-mahato avatar Oct 08 '24 11:10 saahil-mahato

:confused:

appgurueu avatar Oct 27 '24 17:10 appgurueu