JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

[DO NOT MERGE before adding the token] chore: update `codecov-action` to `v4`

Open vil02 opened this issue 1 year ago • 4 comments

Open in Gitpod know more

Describe your change:

Same as TheAlgorithms/Rust#670 - it contains the description of the problem.

Before merging, please add the token from https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings as CODECOV_TOKEN into the repo secrets.

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.

vil02 avatar Feb 02 '24 18:02 vil02

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6aaa376) 82.44% compared to head (8176408) 82.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files         377      377           
  Lines       19747    19747           
  Branches     2884     2885    +1     
=======================================
  Hits        16281    16281           
  Misses       3466     3466           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 02 '24 18:02 codecov-commenter

It seems that in order to add the token, I would have to be logged in (on the codecov site) to access https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings ? I'm slightly uncomfortable with this as it requests permission to "act on my behalf":

Screenshot from 2024-02-02 20-47-06

appgurueu avatar Feb 02 '24 19:02 appgurueu

It seems that in order to add the token, I would have to be logged in (on the codecov site) to access https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings ?

Yes.

I'm slightly uncomfortable with this as it requests permission to "act on my behalf":

I agree.

vil02 avatar Feb 02 '24 19:02 vil02

I bit the bullet and authorized CodeCov to obtain the token, but it turns out that I can't edit repo secrets since I do not have "admin" permissions. This will require @Panquesito7 or @AnupKumarPanwar I believe.

appgurueu avatar May 23 '24 17:05 appgurueu

@appgurueu You should have admin access to the repository now

raklaptudirm avatar Jun 23 '24 05:06 raklaptudirm

Just in case: please make sure that CODECOV_TOKEN is also added to the dependabot secrets (6e27235fb75298833448ba1b23e5178f7eea2290 adds dependabot).

vil02 avatar Jun 23 '24 12:06 vil02

Just in case: please make sure that CODECOV_TOKEN is also added to the dependabot secrets (6e27235 adds dependabot).

Why would dependabot need the codecov token? It seems to work as-is: https://app.codecov.io/github/TheAlgorithms/JavaScript/commit/9010481c2930d65621f18f41c216f29fceaa8807

appgurueu avatar Jun 23 '24 12:06 appgurueu

Without it, the UploadCoverageReport will fail for each PR created by dependabot.

vil02 avatar Jun 23 '24 12:06 vil02