JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

algorithm: SegmentTree

Open changicho opened this issue 3 years ago • 4 comments

Open in Gitpod know more

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

changicho avatar Oct 13 '22 13:10 changicho

Elegant & clever implementation. Can you try to add more comments?

Sure! I add comments in new commit. Please check. Thanks.

changicho avatar Oct 14 '22 09:10 changicho

I was thinking of comments on the implementation details (e.g. how you store the binary tree in a list (same trick as heaps often use), how to calc. the parent pos. from a child pos. and vice versa).

appgurueu avatar Oct 14 '22 09:10 appgurueu

I was thinking of comments on the implementation details (e.g. how you store the binary tree in a list (same trick as heaps often use), how to calc. the parent pos. from a child pos. and vice versa).

I add comments on the implementation details in new commit!

changicho avatar Oct 14 '22 15:10 changicho

@raklaptudirm Could you review this PR? 🙏

changicho avatar Oct 18 '22 11:10 changicho