JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard

Contribute: Added algorithm and tests for Unique Paths DP problem

Open Jaiharishan opened this issue 3 years ago • 9 comments

Open in Gitpod know more

Describe your change:

  • [x] Add an algorithm?
  • [ ] Fix a bug or typo in an existing algorithm?
  • [ ] Documentation change?

Checklist:

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new JavaScript files are placed inside an existing directory.
  • [x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Jaiharishan avatar Oct 03 '22 13:10 Jaiharishan

Do not edit the package-lock.json

Will revert back to the previous one. Is it fine?

Jaiharishan avatar Oct 03 '22 14:10 Jaiharishan

@raklaptudirm I have made the changes you told. Check if its fine now.

Jaiharishan avatar Oct 03 '22 15:10 Jaiharishan

I have made all cases to some under single test block as you said.

Jaiharishan avatar Oct 03 '22 16:10 Jaiharishan

Is this fine now?

Jaiharishan avatar Oct 03 '22 16:10 Jaiharishan

Sure sir

On Mon, 3 Oct 2022, 22:37 Rak Laptudirm, @.***> wrote:

@.**** requested changes on this pull request.

Add some more comments in your code, it can be hard to understand for someone trying to learn.

— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/JavaScript/pull/1118#pullrequestreview-1128740215, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZ5DP2HHTH6VBQDHEFT4NLWBMHGVANCNFSM6AAAAAAQ3SRWZQ . You are receiving this because you authored the thread.Message ID: @.***>

Jaiharishan avatar Oct 03 '22 19:10 Jaiharishan

I have added comments, is it ok now?

Jaiharishan avatar Oct 04 '22 04:10 Jaiharishan

Do I need to change anything sir?

Jaiharishan avatar Oct 05 '22 05:10 Jaiharishan

Will add a explanation then

On Thu, 6 Oct 2022, 00:41 Rak Laptudirm, @.***> wrote:

@.**** requested changes on this pull request.

You should add a short explanation of how the algorithm works.

— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/JavaScript/pull/1118#pullrequestreview-1131918316, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZ5DPYJ3RIRY2IA4JXLJWLWBXHHTANCNFSM6AAAAAAQ3SRWZQ . You are receiving this because you authored the thread.Message ID: @.***>

Jaiharishan avatar Oct 05 '22 23:10 Jaiharishan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 02 '22 01:11 stale[bot]