JavaScript icon indicating copy to clipboard operation
JavaScript copied to clipboard
verified publisher icon TheAlgorithms

Improper and incomplete implementation of CycleDetection.js

Open 10kartik opened this issue 3 years ago • 1 comments

Implementation of CycleDetection.js seems inappropriate.

  • Weird function name main() and its invocation can cause the program to crash.
  • Tests are missing.
  • Not exported, Hence not resuable.
  • Can be optimized further (Optional)

10kartik avatar Sep 13 '22 03:09 10kartik

The algorithm is complete. It has poor code quality though, as you have pointed out. Feel free to fix it.

appgurueu avatar Sep 13 '22 05:09 appgurueu