Java icon indicating copy to clipboard operation
Java copied to clipboard

Update Sparsity.java

Open Swarali-31 opened this issue 1 year ago • 2 comments

Tried to make it more optimised.

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized it.
  • [x] All filenames are in PascalCase.
  • [x] All functions and variable names follow Java naming conventions.
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [x] All new code is formatted with clang-format -i --style=file path/to/your/file.java

Swarali-31 avatar Oct 12 '24 21:10 Swarali-31

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.92%. Comparing base (4a03f42) to head (0674ad4).

Files with missing lines Patch % Lines
src/main/java/com/thealgorithms/misc/Sparsity.java 0.00% 10 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5744      +/-   ##
============================================
+ Coverage     63.91%   63.92%   +0.01%     
+ Complexity     4167     4166       -1     
============================================
  Files           582      582              
  Lines         16302    16301       -1     
  Branches       3148     3146       -2     
============================================
+ Hits          10419    10420       +1     
+ Misses         5457     5455       -2     
  Partials        426      426              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 12 '24 21:10 codecov-commenter

yes sure!

On Sun, Oct 13, 2024 at 11:54 AM Andrii Siriak @.***> wrote:

@.**** requested changes on this pull request.

The code looks good, could you please remove main and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms )

— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/Java/pull/5744#pullrequestreview-2364824076, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASDTQYATIQYAHQAEJCILG5DZ3IGZ5AVCNFSM6AAAAABP2YT2IGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRUHAZDIMBXGY . You are receiving this because you authored the thread.Message ID: @.***>

Swarali-31 avatar Oct 13 '24 06:10 Swarali-31

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

github-actions[bot] avatar Nov 15 '24 00:11 github-actions[bot]

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

github-actions[bot] avatar Nov 23 '24 00:11 github-actions[bot]