Java icon indicating copy to clipboard operation
Java copied to clipboard

Added function and fixed bug in PerfectCube.java

Open TaranjeetSinghKalsi opened this issue 3 years ago • 1 comments

Added another function to PerfectCube.java and fixed a testing mistake in line number 9

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized it.
  • [x] I know that pull requests will not be merged if they fail the automated tests.
  • [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x] All new Java files are placed inside an existing directory.
  • [x] All filenames are in all uppercase characters with no spaces or dashes.
  • [x] All functions and variable names follow Java naming conventions.
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

TaranjeetSinghKalsi avatar Oct 25 '22 10:10 TaranjeetSinghKalsi

The code looks good, could you please add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

Thanks, I have added JUnit tests and also fixed a bug in isPerfectCube() function for negative numbers. Kindly look after it.

TaranjeetSinghKalsi avatar Oct 25 '22 14:10 TaranjeetSinghKalsi

@debasishbsws please review

siriak avatar Oct 29 '22 06:10 siriak