C icon indicating copy to clipboard operation
C copied to clipboard

[FEATURE] Update "list" implementation

Open ybrenning opened this issue 3 years ago • 10 comments

Detailed description

I would like to overhaul the implementation in list.c as it currently seems to be implementing some kind of abstract version of a stack data structure. I would propose to change this to a kind of dynamic array, similar to how the list data type is used in Python or the ArrayList in Java.

I would also like to add some improved documentation in accordance with CONTRIUBUTING.md as well as basic testing to demonstrate the functionality of the list.

The current implementation only allows for pushing to the front of the "list" (no pop operator or possibility for deletion of elements) and has no way of displaying the contents of the list without converting it to an array first and then using a seperately implemented print function which seems unnecessarily convoluted.

Context

I think that this implementation would be a lot more fitting for the list data structure and would be more easy to understand as well as more flexible to use. It would allow for basic operations such as insertion, deletion and printing which aren't entirely possible yet. The improved documentation and simple tests would of course also help in making the code easier to understand.

Possible implementation

Use a struct which keeps track of the current size/length of the list, the current capacity which would allow for resizing and keeps track of the current maximum amount of elements and a pointer to the beginning of the actual elements of the list.

Additional information

No response

ybrenning avatar Aug 24 '22 21:08 ybrenning

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 24 '22 00:09 github-actions[bot]

Thanks for your interest in contributing! 🚀 Would you like to work on all of that? 😃

Let us know if you need any help. Thank you.

Panquesito7 avatar Sep 25 '22 04:09 Panquesito7

Sure, I would like to work on that :)

ybrenning avatar Sep 25 '22 13:09 ybrenning

please assign this to me, i will do it in 2 days

JKP0495 avatar Oct 06 '22 17:10 JKP0495

@ybrenning, are you still willing to work on this? Thanks.

Panquesito7 avatar Oct 29 '22 01:10 Panquesito7

@Panquesito7 @ybrenning Can I work on this issue? And, I would also like to hear what other methods needs to be included apart from the ones below?

append(int val) insert(int val, int index) pop() remove(int index) length() printArray() sort() reverse() index(int value) get(int index)

niranjank2022 avatar Sep 12 '23 15:09 niranjank2022