OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

CI for no differences in .ok file

Open rovinski opened this issue 1 year ago • 2 comments

Description

As a simple sanity check, there could be a CI test that any modified .ok files do not have differences in them. This will ensure that they don't get missed on review.

Suggested Solution

A simple script which greps for "Differences found at line" should suffice.

Additional Context

No response

rovinski avatar Jun 08 '24 20:06 rovinski

@vvbandeira could this be a GH action?

maliberty avatar Jun 09 '24 11:06 maliberty

@vvbandeira could this be a GH action?

I think Jenkins should be fine. It would be a simple grep "Differences found at line" **/*.ok or for f in **/*.ok; do ... plus some minor parsing/substitutions just to print the names of the tests in a nice format.

vvbandeira avatar Jun 11 '24 13:06 vvbandeira

Resolved by #7389

rovinski avatar May 22 '25 06:05 rovinski