OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

mpl2: hardmacro placement refactoring

Open AcKoucher opened this issue 1 year ago • 1 comments

Small steps to make the hierarchical macro placement stage more friendly..

AcKoucher avatar Feb 19 '24 22:02 AcKoucher

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 19 '24 22:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 29 '24 14:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 06 '24 02:03 github-actions[bot]

Secure-CI for this showed two failures which seem to be on master as well:

 --> asap7/mock-array:
[ERROR CI-0000] No error message found. Here are the last 10 lines of the log.
41# 0x00007F1DFC3E7F1E in /lib64/[libtcl8.5.so](http://libtcl8.5.so/)
          42# Tcl_EvalEx in /lib64/[libtcl8.5.so](http://libtcl8.5.so/)
          43# Tcl_Eval in /lib64/[libtcl8.5.so](http://libtcl8.5.so/)
          44# sta::sourceTclFile(char const*, bool, bool, Tcl_Interp*) in /tmp/workspace/rivate_secure-mpl2_refactor_hard/tools/install/OpenROAD/bin/openroad
          45# ord::tclAppInit(Tcl_Interp*) in /tmp/workspace/rivate_secure-mpl2_refactor_hard/tools/install/OpenROAD/bin/openroad
          46# Tcl_Main in /lib64/[libtcl8.5.so](http://libtcl8.5.so/)
          47# main in /tmp/workspace/rivate_secure-mpl2_refactor_hard/tools/install/OpenROAD/bin/openroad
          48# __libc_start_main in /lib64/libc.so.6
          49# 0x0000000000D7AAF7 in /tmp/workspace/rivate_secure-mpl2_refactor_hard/tools/install/OpenROAD/bin/openroad
          Elapsed time: 0:03.85[h:]min:sec. CPU time: user 3.71 sys 0.13 (99%). Peak memory: 562420KB.

--> gf180 aes-hybrid (base)
  Flow reached last stage.
  Found 42 errors in the logs.
      [ERROR] LEF Cell 'gf180mcu_fd_sc_mcu7t5v0__nor2_2' has no matching GDS/OAS cell. Cell will be empty.
      [ERROR] LEF Cell 'gf180mcu_fd_sc_mcu7t5v0__xnor2_2' has no matching GDS/OAS cell. Cell will be empty.
      [... more LEF problems ...]

AcKoucher avatar Mar 06 '24 16:03 AcKoucher

This seems to have gotten a bit lost. This has a conflict to resolve - is it otherwise ready?

maliberty avatar Apr 04 '24 20:04 maliberty

@maliberty I was ready, I'll double check due to the later changes..

AcKoucher avatar Apr 05 '24 19:04 AcKoucher

There is a conflict to resolve

maliberty avatar Apr 06 '24 03:04 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 08 '24 18:04 github-actions[bot]

Ready for review

AcKoucher avatar Apr 08 '24 20:04 AcKoucher