engine_components
engine_components copied to clipboard
Documentation for IfcFragmentSettings.optionalCategories is misleading
Describe the bug 📝
The documentation for this setting states: "Generate the geometry for categories that are not included by default, like IFCSPACE."
However, IfcSpaces are included by default when loading an IFC file. Furthermore, it seems that is setting is never checked when deciding which entities to process and which to skip. Only includedCategories and excludedCategories are checked. Could it be that this setting is deprecated?
Source file: https://github.com/ThatOpen/engine_components/blob/main/packages/core/src/fragments/IfcLoader/index.ts
Code:
Reproduction ▶️
No response
Steps to reproduce 🔢
No response
System Info 💻
components: 2.4.3
web-ifc: 0.0.66
Used Package Manager 📦
npm
Error Trace/Logs 📃
No response
Validations ✅
- [x] Read the docs.
- [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- [X] Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
- [X] Check that this is a concrete bug. For Q&A join our Community.
- [X] The provided reproduction is a minimal reproducible example of the bug.