Setting ifcLoader.settings.includeProperties to "false" has no effect

[andy-wrks]

Describe the bug 📝

It seems that the setting ifcLoader.settings.includeProperties isn't respected when loading an IFC file.

It could be that the bug is in the code below. It looks like when calling ifcLoader.load(), IfcJsonExporter is used without checking this setting.

Source file: https://github.com/ThatOpen/engine_components/blob/main/packages/core/src/fragments/IfcLoader/index.ts

Code:

Disabling this setting can be useful when properties are not needed or handled independently. Skipping this step will then reduce computation time.

Reproduction ▶️

No response

Steps to reproduce 🔢

...
ifcLoader.settings.includeProperties = false;
...
const group = await ifcLoader.load(buffer);
const props = group.getLocalProperties();

// the properties are present, but they shouldn't

System Info 💻

components: 2.4.3
web-ifc: 0.0.66

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• [X] Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
• [X] Check that this is a concrete bug. For Q&A join our Community.
• [X] The provided reproduction is a minimal reproducible example of the bug.