engine_components icon indicating copy to clipboard operation
engine_components copied to clipboard

Set maximum size exceeded in FragmentPropsStreamConverter

Open RyugaRyuzaki opened this issue 1 year ago • 1 comments

Describe the bug 📝

  • When I load a model ~1.3 GB, the program will throw an error about Set at this line https://github.com/ThatOpen/engine_components/blob/main/src/fragments/FragmentIfcStreamer/src/fragment-props-stream-converter.ts#L121

  • That reminds me of the problem above https://stackoverflow.com/questions/72809513/how-do-i-know-what-is-the-size-limit-for-constructing-a-set-in-javascript

Reproduction ▶️

No response

Steps to reproduce 🔢

If instead of using Set, can we replace it with an array, I know this makes the filtering process difficult. An idea might be GeometryTypes:{[id:number]:number} instead of Set

System Info 💻

/////

Used Package Manager 📦

npm

Error Trace/Logs 📃

/////

Validations ✅

  • [X] Read the docs.
  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • [X] Check that this is a concrete bug. For Q&A join our Community.
  • [X] The provided reproduction is a minimal reproducible example of the bug.

RyugaRyuzaki avatar Apr 02 '24 06:04 RyugaRyuzaki

there currently seems to be a size limit to what the props stream converter can handle. i was told it is being worked on.

kitsunekyo avatar May 16 '24 06:05 kitsunekyo