engine_components icon indicating copy to clipboard operation
engine_components copied to clipboard

SimpleClipper component improvements

Open TristanLecallier opened this issue 2 years ago • 0 comments

Description 📝

Hi !

  • Currently once one or several planes have been created using EdgesClipper (or SimpleClipper) component, by disabling the component with a custom button, planes already created are desactivated. (this seems to be treated in https://github.com/IFCjs/components/issues/130#issuecomment-1836448032 issue)
  • Currently, it is not possible to delete a plane when EdgeClipper is disabled : "delete" method of SimpleClipper component return "undefined" when disabled. (https://github.com/IFCjs/components/blob/a8472b228f955fd03a9c1e16d05d46106f496466/src/core/SimpleClipper/index.ts#L216)
  • Consequently, if I want to delete all planes (with "deleteAll" method) when EdgeClipper is disabled, I get in an infinite loop (https://github.com/IFCjs/components/blob/a8472b228f955fd03a9c1e16d05d46106f496466/src/core/SimpleClipper/index.ts#L228).

Suggested solution 💡

  • When disabling the component, let the possibility to keep activated existing planes
  • Let the possibility to delete an existing plane when the component is disabled

Alternative ⛕

No response

Additional context ☝️

No response

Validations ✅

  • [X] Read the docs.
  • [X] Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

TristanLecallier avatar Dec 05 '23 15:12 TristanLecallier