that.us icon indicating copy to clipboard operation
that.us copied to clipboard

Hybrid event types should show start and ending time, not just starting.

Open theClarkSell opened this issue 4 years ago • 9 comments

image

theClarkSell avatar Jun 14 '21 15:06 theClarkSell

@csell5 will the event end date always be different than the event start date? Or should we code for the case where they're the same to only display the one date?

joshpierce avatar Jun 15 '21 15:06 joshpierce

Great question. We shouldn't assume that it will always be different. Hybrid events should always fall into a multi day scenario but they don't have too.

Rather than showing an end date, what if we show the number of days long it is.. So Starting Date - Day's long? That's more what someone would want to know anyways.

theClarkSell avatar Jun 15 '21 15:06 theClarkSell

We could show the # of Days for the event like such:

image

In the current scenario, the diff of startDate (2021-07-26T11:00:30.904Z) to endDate (2021-07-29T23:00:01.652Z) is evaluating to 3.4996614351851854 days.

  • Should this show as 4 days (in the above SS I'm using Math.ceil() to round the result up)? Doing so would mean if you have a small discrepancy in time, you could end up with something like 3.0001 days difference coming out as a 4 day event.
  • Should it be rounded to the nearest half day instead, and be represented as 3.5 days?
  • I don't know how feasible this would be, but could we add a property of duration to the events that get returned, so that it could be defined independently of a calculation? (Examples: 4 Day Event, Single Day Event, Morning Coffee Chat, Afternoon Happy Hour, Midnight Hackathon). Admittedly this could be overcomplicating it, but would give more flexibility.

joshpierce avatar Jun 15 '21 23:06 joshpierce

@brettski how do you feel about us adding another field (enum with display prop) to the event type around this vs calculating things? I know we have our own event type already but maybe this is an expansion on that.

theClarkSell avatar Jun 16 '21 00:06 theClarkSell

What values are thinking of for this enum @csell5 ?

brettski avatar Jun 16 '21 00:06 brettski

Well I was just expanding on @joshpierce last point.. maybe an enum isn't the right choice..

theClarkSell avatar Jun 16 '21 00:06 theClarkSell

If we are looking for whole days I would think Ceiling would provide the correct number of days in 99% of the scenarios.

brettski avatar Jun 16 '21 00:06 brettski

I think the spirit was to be more flexible than just assuming it's a day value.

theClarkSell avatar Jun 16 '21 00:06 theClarkSell

FYI you will need to rebase on top of #753 as I had to make some changes which would be in conflict here.

theClarkSell avatar Jun 17 '21 00:06 theClarkSell