Texture icon indicating copy to clipboard operation
Texture copied to clipboard

avoid padding a struct to be hashed

Open wsdwsd0829 opened this issue 4 years ago • 2 comments

alternatively

  • (NSUInteger)hash { #pragma pack(push,1) struct { CGSize viewportSize; ASScrollDirection scrollableDirections; NSUInteger elementsHash; NSUInteger layoutDelegateClassHash; NSUInteger additionalInfoHash; } data = { _viewportSize, _scrollableDirections, _elements.hash, _layoutDelegateClass.hash, [_additionalInfo hash] }; #pragma pack(pop) return ASHashBytes(&data, sizeof(data)); }

I am less confident about what #pragma pack(push,1) is doing

wsdwsd0829 avatar Sep 14 '21 02:09 wsdwsd0829

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 14 '21 02:09 CLAassistant

Let's try these things and see if they work:

  • Try setting the values of the struct explicitly like the comment in ASHashBytes suggests
  • Try changing the type of ASScrollDirection from unsigned char to NSUInteger

If neither of those work, let's land this! :)

rcancro avatar Sep 17 '21 17:09 rcancro