Texture icon indicating copy to clipboard operation
Texture copied to clipboard

Decode alternative image types in ASImageNode at render time

Open brandonli-google opened this issue 4 years ago • 3 comments

Adds support at the Texture level for decoding additional image formats at render time once the final image size is known

The Cartfile changes are because ASPINRemoteImageDownloader currently references API's that don't exist in the older version of PINRemoteImage

See https://github.com/pinterest/PINRemoteImage/pull/602 for corresponding PINRemoteImage change

Upstreamed contribution from Google's fork of Texture

brandonli-google avatar Jun 24 '21 20:06 brandonli-google

Just to confirm, this change requires the PINRemoteImage change be merged and released?

garrettmoon avatar Jul 02 '21 17:07 garrettmoon

Just to confirm, this change requires the PINRemoteImage change be merged and released?

Yes, that's right. Could add an additional build directive into PINRemoteImage (like #PINCustomDecoders or something) so that they can go in independently. WDYT?

brandonli-google avatar Jul 02 '21 21:07 brandonli-google

I don't think that's necessary, PINRemoteImage is due a release soon anyway :)

garrettmoon avatar Jul 02 '21 21:07 garrettmoon