Texture Fix alwaysHandleTruncationTokenTap

Previously enabling alwaysHandleTruncationTokenTap would break passthroughNonlinkTouches as it didn’t check if the tap was in the additionalTruncationMessage.

Feature introduced here https://github.com/TextureGroup/Texture/pull/1520

Mar 26 '20 18:03 ay8s

Thanks for the fix, @ay8s. Would it be possible to have unit/snapshot tests to make sure we won't regress again?

Btw, there was a build failure that looks like a fluke so I re-ran them all 🤞

Mar 26 '20 19:03 nguyenhuy

👍 I'll see if I get chance to circle back and add one. Right now I don't think we have any ASTextNode2 tests around link touches.

Mar 26 '20 20:03 ay8s

@ay8s have any luck looking into tests for this?

Apr 02 '20 00:04 jparise

@jparise Not just yet. I'll take a look at it later this week hopefully.

Apr 02 '20 01:04 ay8s

@jparise Got halfway there, would love to perhaps pair in Slack how best to tackle testing this. Seems something could be added to both ASTextNode and ASTextNode2.

Apr 02 '20 02:04 ay8s

@jparise Got halfway there, would love to perhaps pair in Slack how best to tackle testing this. Seems something could be added to both ASTextNode and ASTextNode2.

I think @nguyenhuy would be the best person to guide you through this one.

Apr 02 '20 02:04 jparise

@ay8s Feel free to ping me there with more details!

Apr 02 '20 06:04 nguyenhuy

@ay8s have you gotten a chance to sync on the best way to write a test for this?

Apr 07 '20 18:04 jparise

I've just pinged @nguyenhuy on Slack. We have quite a bit on with some upcoming features at Buffer which takes priority but will see if me and Huy can work on this soon.

Apr 07 '20 22:04 ay8s

All committers have signed the CLA.

Jan 31 '21 05:01 CLAassistant

@ay8s looks like it's just the CLA check which is blocking this. Mind signing that?

Feb 05 '21 17:02 jparise

Is there any chance this could be merged, please?

Oct 02 '21 20:10 mohamede1945