Texture icon indicating copy to clipboard operation
Texture copied to clipboard

[ASMultiplexImageNode] Avoid holding on to its lock while calling out to downloader

Open nguyenhuy opened this issue 7 years ago • 3 comments

nguyenhuy avatar Nov 27 '18 00:11 nguyenhuy

@nguyenhuy There's another case of the same pattern just below, in -didEnterVisibleState. Did you happen to see or by code inspection identify any risk of lock interleaving?

We should decide whether the node's lock or the downloader's lock is higher precedence, and then as long as we are using them in that sequence, it would not be necessary to unlock when calling the other.

appleguy avatar Nov 27 '18 01:11 appleguy

I just happened to look at this method and noticed that we're doing it differently in ASNetworkImageNode.

nguyenhuy avatar Nov 27 '18 01:11 nguyenhuy

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 31 '21 05:01 CLAassistant