Texture icon indicating copy to clipboard operation
Texture copied to clipboard

[ASNetworkImageNode] For GIFs, imageNode:didLoadImage:info is not called.

Open yang152412 opened this issue 7 years ago • 7 comments

ASNetworkImageNode does not called delegate method imageNode:didLoadImage:info if the URL is gif. And imageNode:didLoadImage:info image will be nil if image is an animated image.So why not support ASImageContainerProtocol ? it's really convenience.

yang152412 avatar Sep 17 '18 08:09 yang152412

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 17 '18 08:09 CLAassistant

🚫 CI failed with log

ghost avatar Sep 17 '18 14:09 ghost

🚫 CI failed with log

ghost avatar Sep 25 '18 14:09 ghost

I assume this would fix #1070?

cesteban avatar Oct 05 '18 18:10 cesteban

@nguyenhuy Any reason this is dead?

foxware00 avatar Sep 20 '19 15:09 foxware00

@yang152412 would you mind rebasing this PR?

jparise avatar Jan 02 '20 19:01 jparise

This still doesn't work in Texture 3.0.0 as of January 22, 2022 - I'm forced to use imageNodeWillStartDisplayAsynchronously for now 😞 -- could use imageNodeDidFinishDecoding but it looks like that is called several times for GIFs, so make sure you add logic around that behavior for whatever it is you're trying to accomplish.

JoeFerrucci avatar Jan 22 '22 20:01 JoeFerrucci