toolong icon indicating copy to clipboard operation
toolong copied to clipboard

Upgrade textual and python

Open bluefing opened this issue 1 year ago • 4 comments

  • Upgrading textual to 0.82.0 required minor Python version bump
  • Minimal change required due to namespace_bindings rename to active_bindings in Textual 0.61.0
  • Limited post upgrade testing.
    • Performed manual smoke test by piping tree into tl and reading a python log file

bluefing avatar Oct 26 '24 21:10 bluefing

More testing required - tailing is not working

bluefing avatar Oct 27 '24 00:10 bluefing

Reopening the PR as tail is working when tl is executed stand alone. Tail was not working when I had embedded it in another app.

bluefing avatar Oct 27 '24 11:10 bluefing

Discovered this issue while testing the PR with toolong embedded in another app. I'll have a look at it to make sure it does not impact stand alone usage.

I suspect it will as

App.check_bindings is now private https://github.com/Textualize/textual/blob/main/CHANGELOG.md#0690---2024-06-16

image

bluefing avatar Oct 27 '24 12:10 bluefing

tested that the following are working using Python 3.12.7

  • passing multiple log files
    • tabbed tl ../logs/app.log ../logs/app.log.2
    • merged tl --merge ../logs/app.log ../logs/app.log.2
  • Find
    • Regex and case sensitive search
    • previous and next
  • Go to
  • Line nos
  • Help
  • Mouse (scroll and shift-scroll) and keyboard navigation (g, shift-g, page-up/down, arrow keys)
  • Overlay

bluefing avatar Oct 27 '24 13:10 bluefing