textual icon indicating copy to clipboard operation
textual copied to clipboard
verified publisher icon Textualize

Deliver file

Open darrenburns opened this issue 1 year ago • 2 comments

Please review the following checklist.

  • [ ] Docstrings on all new or modified functions / classes
  • [ ] Updated documentation
  • [ ] Updated CHANGELOG.md (where appropriate)

darrenburns avatar Aug 12 '24 13:08 darrenburns

@willmcgugan Feel free to review. Would appreciate 👀s on this.

darrenburns avatar Aug 12 '24 14:08 darrenburns

Just to say, we should hold off merging this until everything is in place.

willmcgugan avatar Aug 26 '24 13:08 willmcgugan

FYI @darrenburns, just wanted to point out that the version platformdirs = ^4.2.2 breaks our poetry build -- I believe since you only need the user_downloads_path, you could loosen the version restriction to >=3.6.0 (this commit on the platformdirs repo is tagged all the way down to 3.6.0). I can handle this change in another PR if you like.

JaceyPenny avatar Sep 03 '24 15:09 JaceyPenny

PR would be welcome.

willmcgugan avatar Sep 03 '24 16:09 willmcgugan