rich icon indicating copy to clipboard operation
rich copied to clipboard
verified publisher icon Textualize

Add new column object: IterationSpeedColumn

Open chthollyphile opened this issue 2 years ago • 2 comments

Type of changes

  • [ ] Bug fix
  • [x] New feature
  • [ ] Documentation / docstrings
  • [ ] Tests
  • [ ] Other

Checklist

  • [x] I've run the latest black with default args on new code.
  • [x] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • [x] I've added tests for new code.
  • [x] I accept that @willmcgugan may be pedantic in the code review.

Description

This pull request addresses the requirement raised in discussion #926 to add a new column for the number of iterations per second.

chthollyphile avatar Apr 15 '24 23:04 chthollyphile

Looks good. I'd need tests for the new column. And an entry in the docs.

willmcgugan avatar Jul 01 '24 20:07 willmcgugan

done.

chthollyphile avatar Jul 05 '24 17:07 chthollyphile

Thanks

willmcgugan avatar Sep 30 '24 14:09 willmcgugan

Had to revert this PR I'm afraid. Assigning an attribute with setattr is a deal-breaker. It doesn't play well with static type checkers, and is best avoided. Can you not store the value on the Column object?

willmcgugan avatar Sep 30 '24 19:09 willmcgugan